Change CacheFile.LogMessages type to Ilist<AssetsLogMessage> #6132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nkolev92
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Thinking about this again and based on this comment: https://github.com/NuGet/NuGet.Client/pull/6081/files#r1825078556, I'm not sure it's worth breaking an API here.
The casting is also adding allocations and I'm not sure that trade off is worth it.
Let's resolve the other conversation first though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13898
Description
The
IAssetsLogMessageinterface was removed in favor of using the concreteAssetsLogMessageclass directly inCacheFile.LogMessagesbecauseAssetsLogMessageis a Data Transfer Object (DTO) with no business logic. DTOs do not require interfaces since they serve solely as data carriers, and no need for polymorphism. This change simplifies serialization by removing the need for custom converters and reduces unnecessary abstraction.This will be useful for the following PR: #6081
PR Checklist